feat(python-sdk): validate config#72
Open
czi-fsisenda wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds fail-fast validation in the Python SDK to ensure an EvaluatorConfig includes provider configs for every LLMProvider referenced by the active EvaluationSettings (both at evaluator construction time and per-evaluation).
Changes:
- Added
EvaluatorConfig.validate_supports_evaluation_settings()plus provider discovery overPromptSettingsfields onEvaluationSettings. - Enforced provider-config validation in
BaseEvaluator.__init__(resolved defaults) and at the start ofBaseEvaluator.evaluate()(per-run settings). - Updated unit/contract tests and test fixtures to supply provider configs where evaluators’ defaults require them; added targeted validation tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdks/python/src/learning_commons_evaluators/schemas/config.py | Introduces provider requirement detection from settings and config validation with ConfigurationError. |
| sdks/python/src/learning_commons_evaluators/evaluators/base.py | Calls config validation during evaluator init and before each evaluation run. |
| sdks/python/README.md | Documents new provider config validation behavior and where it runs. |
| sdks/python/tests/conftest.py | Adds fixtures providing Google / Google+OpenAI configs for tests. |
| sdks/python/tests/schemas/test_config.py | Adds unit tests for validate_supports_evaluation_settings() behavior (no-op, missing provider(s), multiple providers). |
| sdks/python/tests/evaluators/test_base.py | Adds tests ensuring init/evaluate raise ConfigurationError when required provider config is missing. |
| sdks/python/tests/evaluators/test_vocabulary.py | Updates tests to use provider-configured fixtures due to new validation. |
| sdks/python/tests/evaluators/test_conventionality.py | Updates tests to use provider-configured fixture due to new validation. |
| sdks/python/tests/contract_tests/test_vocabulary.py | Updates contract tests to use provider-configured fixture due to new validation. |
| sdks/python/tests/contract_tests/test_conventionality.py | Updates contract tests to use provider-configured fixture due to new validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan